pawelpasterz commented on a change in pull request #11076: Run precommit 
portability on java 11
URL: https://github.com/apache/beam/pull/11076#discussion_r392319004
 
 

 ##########
 File path: build.gradle
 ##########
 @@ -335,3 +335,27 @@ if (project.hasProperty('javaLinkageArtifactIds')) {
     }
   }
 }
+
+if (project.hasProperty('runWithJava11')) {
+  allprojects {
+    plugins.withId('java') {
+
+      java {
+        sourceCompatibility = JavaVersion.VERSION_1_8
+        targetCompatibility = JavaVersion.VERSION_1_8
+      }
+
+      tasks.withType(JavaCompile) {
+        options.with {
+          fork = true
+          forkOptions.javaHome = java8Home as File
+        }
+      }
+
+      test {
 
 Review comment:
   @Ardagan 
   Hey! I've added verification test to check bytecode and jvm.  It is launched 
only with `-PrunWithJava11` flag. I've already checked few jobs and did not 
noticed anything wrong. Let me know what do you think, thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to