chadrik commented on a change in pull request #11038: [BEAM-7746] More typing
fixes
URL: https://github.com/apache/beam/pull/11038#discussion_r393183860
##########
File path: sdks/python/apache_beam/io/iobase.py
##########
@@ -244,7 +272,7 @@ def is_bounded(self):
return True
-class RangeTracker(object):
+class RangeTracker(Generic[PositionT]):
Review comment:
@udim For the base `RangeTracker` if we only consider the methods
implemented by the class the "position" type could be `Any`, but based on the
docs it seemed that any meaningful position would be comparable/sortable. Let
me know if you think we should move the `Position` restriction down to a
subclass.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
