udim commented on a change in pull request #11038: [BEAM-7746] More typing fixes
URL: https://github.com/apache/beam/pull/11038#discussion_r394026348
##########
File path: sdks/python/apache_beam/io/range_trackers.py
##########
@@ -233,19 +254,25 @@ class OrderedPositionRangeTracker(iobase.RangeTracker):
UNSTARTED = object()
def __init__(self, start_position=None, stop_position=None):
+ # type: (Optional[iobase.PositionT], Optional[iobase.PositionT]) -> None
self._start_position = start_position
self._stop_position = stop_position
self._lock = threading.Lock()
- self._last_claim = self.UNSTARTED
+ # the return on investment for properly typing this is low. cast it.
Review comment:
Did you mean that the ROI is high, not low?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
