Ardagan commented on a change in pull request #11076: Run precommit portability
on java 11
URL: https://github.com/apache/beam/pull/11076#discussion_r393832528
##########
File path: sdks/java/testing/test-utils/build.gradle
##########
@@ -39,3 +39,14 @@ dependencies {
testCompile library.java.hamcrest_library
testRuntimeOnly project(path: ":runners:direct-java", configuration:
"shadowTest")
}
+
+task verifyJavaVersion(type: Test) {
+ filter {
+ includeTestsMatching
'org.apache.beam.sdk.testutils.jvmverification.JvmVerification.verifyCodeIsCompiledWithJava8'
+ includeTestsMatching
'org.apache.beam.sdk.testutils.jvmverification.JvmVerification.verifyTestCodeIsCompiledWithJava8'
Review comment:
We should add test that compiles beam with java8 and tests with java11. This
use case is more important. I don't think it is common to compile your pipeline
with Java8 and then run with Java11.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
