Ardagan commented on a change in pull request #11076: Run precommit portability
on java 11
URL: https://github.com/apache/beam/pull/11076#discussion_r393831160
##########
File path: sdks/java/testing/test-utils/build.gradle
##########
@@ -39,3 +39,14 @@ dependencies {
testCompile library.java.hamcrest_library
testRuntimeOnly project(path: ":runners:direct-java", configuration:
"shadowTest")
}
+
+task verifyJavaVersion(type: Test) {
Review comment:
It is best to generalize this method since we have different options like:
Java8 Beam, Java 8 Test, Java 8 runtime
Java8 Beam, Java 11 Test, Java 11 runtime
eventually we will add
Java11 Beam, Java 8 Test, Java 8 runtime
Java11 Beam, Java 11 Test, Java 11 runtime
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
