youngoli commented on a change in pull request #11144: [BEAM-3301] Perform SDF
validation (missing RestrictionTrackers).
URL: https://github.com/apache/beam/pull/11144#discussion_r394783477
##########
File path: sdks/go/pkg/beam/core/graph/fn_test.go
##########
@@ -470,6 +542,169 @@ func (fn *BadDoFnAmbiguousSideInput) StartBundle(bool) {
func (fn *BadDoFnAmbiguousSideInput) FinishBundle(bool) {
}
+// Examples of correct SplittableDoFn signatures
+
+type RestT struct{}
+
+type GoodSdf struct {
Review comment:
I was just skipping it because this commit hasn't added restriction trackers
yet, but adding a TODO to remind me to change it later is a good idea. Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
