youngoli commented on a change in pull request #11144: [BEAM-3301] Perform SDF
validation (missing RestrictionTrackers).
URL: https://github.com/apache/beam/pull/11144#discussion_r394783417
##########
File path: sdks/go/pkg/beam/core/graph/fn.go
##########
@@ -196,13 +217,31 @@ func (f *DoFn) Name() string {
// IsSplittable returns whether the DoFn is a valid Splittable DoFn.
func (f *DoFn) IsSplittable() bool {
- return false // TODO(BEAM-3301): Implement this when we add SDFs.
+ isSdf, _ := validateSdfMethodsPresent((*Fn)(f))
Review comment:
Good point, I'll keep it in mind for the future. For this one, though, I
realized it's better just to check for the presence of a single SDF method
anyway, rather than calling that validation method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
