robertwb commented on a change in pull request #11162: [BEAM-9339, BEAM-2939]
Drop splittable field from ParDoPayload, add splittable dofn requirement to
Python SDK.
URL: https://github.com/apache/beam/pull/11162#discussion_r395213529
##########
File path: model/pipeline/src/main/proto/beam_runner_api.proto
##########
@@ -1355,6 +1355,10 @@ message StandardRequirements {
// This requirement indicates the requires_time_sorted_input field of ParDo
// transform payloads must be inspected.
REQUIRES_TIME_SORTED_INPUT = 3 [(beam_urn) =
"beam:requirement:pardo:time_sorted_input:v1"];
+
+ // This requirement indicates the restriction_coder_id field of ParDo
+ // transform payloads must be inspected.
+ REQUIRES_SPLITTABLE_DOFN = 4 [(beam_urn) =
"beam:requirement:pardo:splittable_dofn:v1"];
Review comment:
Is this a requirement, given that the pipeline would still execute correctly
were expansion not performed? (Maybe the performance is bad enough to merit
this, but then again, maybe SDF is so primitive that all runners should do
something do support sources.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
