lukecwik commented on a change in pull request #11162: [BEAM-9339, BEAM-2939]
Drop splittable field from ParDoPayload, add splittable dofn requirement to
Python SDK.
URL: https://github.com/apache/beam/pull/11162#discussion_r395220391
##########
File path: model/pipeline/src/main/proto/beam_runner_api.proto
##########
@@ -457,10 +457,9 @@ message ParDoPayload {
// be placed in the pipeline requirements.
map<string, TimerFamilySpec> timer_family_specs = 9;
- // Whether the DoFn is splittable
- bool splittable = 6;
-
- // (Required if splittable == true) Id of the restriction coder.
+ // (Optional) Only set when this ParDo contains a splittable DoFn.
Review comment:
`splittable` is invalid without the other field being set so why have it?
It would allow for bugs where one is set and the other is not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
