chamikaramj commented on a change in pull request #11122: [BEAM-9346] Improve
the efficiency of TFRecordIO
URL: https://github.com/apache/beam/pull/11122#discussion_r395391171
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/WriteFiles.java
##########
@@ -410,13 +412,44 @@ private GatherResults(Coder<ResultT> resultCoder) {
} else {
// Pass results via a side input rather than reshuffle, because we
need to get an empty
// iterable to finalize if there are no results.
- return input
- .getPipeline()
- .apply(Reify.viewInGlobalWindow(input.apply(View.asList()),
ListCoder.of(resultCoder)));
+ return input.apply("ToList", Combine.globally(new
ToListCombineFn<>()));
Review comment:
Seems like this was applied to all file-based IO not just TFRecordIO as
mentioned in the PR description. Have we done enough experiments to make sure
this won't have unintended adverse performance consequences in batch/streaming
? For example, what if the list does not fit in memory ?
Apologies if this was already discussed in the dev list.
cc: @robertwb @lukecwik @iemejia
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
