lukecwik commented on a change in pull request #11122: [BEAM-9346] Improve the
efficiency of TFRecordIO
URL: https://github.com/apache/beam/pull/11122#discussion_r395415747
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/WriteFiles.java
##########
@@ -410,13 +412,44 @@ private GatherResults(Coder<ResultT> resultCoder) {
} else {
// Pass results via a side input rather than reshuffle, because we
need to get an empty
// iterable to finalize if there are no results.
- return input
- .getPipeline()
- .apply(Reify.viewInGlobalWindow(input.apply(View.asList()),
ListCoder.of(resultCoder)));
+ return input.apply("ToList", Combine.globally(new
ToListCombineFn<>()));
}
}
}
+ public static class ToListCombineFn<ResultT>
Review comment:
nit: This should have been private class since its an implementation detail
and didn't need to expose this to users of the WriteFiles transform.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
