[
https://issues.apache.org/jira/browse/BEAM-295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289185#comment-15289185
]
ASF GitHub Bot commented on BEAM-295:
-------------------------------------
GitHub user aljoscha opened a pull request:
https://github.com/apache/incubator-beam/pull/347
[BEAM-295] Remove erroneous close() calls in Flink Create Sources
Collector.close() should only be called by internal Flink components,
not by user functions.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aljoscha/incubator-beam remove-collector-close
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/347.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #347
----
commit bd658bfb3d36e047eacecc91146b051b91eebf1b
Author: Aljoscha Krettek <[email protected]>
Date: 2016-05-18T15:46:34Z
[BEAM-295] Remove erroneous close() calls in Flink Create Sources
Collector.close() should only be called by internal Flink components,
not by user functions.
----
> Flink Create Functions call Collector.close()
> ---------------------------------------------
>
> Key: BEAM-295
> URL: https://issues.apache.org/jira/browse/BEAM-295
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Reporter: Aljoscha Krettek
> Assignee: Aljoscha Krettek
>
> {{Collector.close()}} should only be called internally, by Flink. Calling
> close() in the user function, as we do in {{FlinkCreateFunction}} and
> {{FlinkStreamingCreateFunction}} will lead to downstream operations being
> closed twice, which can lead to faulty behavior.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
