[
https://issues.apache.org/jira/browse/BEAM-295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15292665#comment-15292665
]
ASF GitHub Bot commented on BEAM-295:
-------------------------------------
GitHub user kennknowles opened a pull request:
https://github.com/apache/incubator-beam/pull/364
[BEAM-295] Remove erroneous close() calls in Flink Create Sources
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
Collector.close() should only be called by internal Flink components,
not by user functions.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/incubator-beam copy-347
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/364.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #364
----
commit bd658bfb3d36e047eacecc91146b051b91eebf1b
Author: Aljoscha Krettek <[email protected]>
Date: 2016-05-18T15:46:34Z
[BEAM-295] Remove erroneous close() calls in Flink Create Sources
Collector.close() should only be called by internal Flink components,
not by user functions.
----
> Flink Create Functions call Collector.close()
> ---------------------------------------------
>
> Key: BEAM-295
> URL: https://issues.apache.org/jira/browse/BEAM-295
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Reporter: Aljoscha Krettek
> Assignee: Aljoscha Krettek
>
> {{Collector.close()}} should only be called internally, by Flink. Calling
> close() in the user function, as we do in {{FlinkCreateFunction}} and
> {{FlinkStreamingCreateFunction}} will lead to downstream operations being
> closed twice, which can lead to faulty behavior.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
