[
https://issues.apache.org/jira/browse/BEAM-25?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15553512#comment-15553512
]
ASF GitHub Bot commented on BEAM-25:
------------------------------------
GitHub user kennknowles opened a pull request:
https://github.com/apache/incubator-beam/pull/1064
[BEAM-25] Add StateSpec as a curried way to build a StateTag
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [x] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
This is an alternative to #1044, based on lessons learned there. Instead of
moving the disjoint union destruction to `StateSpec` and rebuilding `StateTag`
= `StateSpec` + ID I have instead written `StateSpec` = `StateTag` - ID :-)
I tend to think that `StateSpec` "should" be an independent thing, but that
would mean the ability to `bind` it to a state cell without providing an ID.
Given current design considerations, I don't think that fits as well. So
instead, this PR just embraces the fact that a `StateSpec` has no real
independent meaning, but is just a curried form of `StateTag` for use in the
proposed state API.
I'm curious if you have a preference.
R: @bjchambers AND @tgroh AND @aljoscha
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/incubator-beam StateSpec-curry
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1064.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1064
----
commit bc9e4b64bb68bf35e74cfb459a727b1a34655b2c
Author: Kenneth Knowles <[email protected]>
Date: 2016-10-06T22:46:44Z
Add StateSpec as a curried way to build a StateTag
----
> Add user-ready API for interacting with state
> ---------------------------------------------
>
> Key: BEAM-25
> URL: https://issues.apache.org/jira/browse/BEAM-25
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-core
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Labels: State
>
> Our current state API is targeted at runner implementers, not pipeline
> authors. As such it has many capabilities that are not necessary nor
> desirable for simple use cases of stateful ParDo (such as dynamic state tag
> creation). Implement a simple state intended for user access.
> (Details of our current thoughts in forthcoming design doc)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
