[
https://issues.apache.org/jira/browse/BEAM-25?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15635004#comment-15635004
]
ASF GitHub Bot commented on BEAM-25:
------------------------------------
GitHub user kennknowles opened a pull request:
https://github.com/apache/incubator-beam/pull/1282
[BEAM-25] DoFnInvoker support for State and Timer params
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [x] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
R: @jkff
The last three commits are new. Perhaps while prerequisites receive further
review you could suggest some intresting tests? I have just a couple, which
just make sure the parameter gets passed, and rely somewhat on compositionality
to ensure that is sufficient.
CC: @tgroh blocked on prior #1252
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/incubator-beam State-Params
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1282.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1282
----
commit 349cb2c5d3c2d92bb4925a0c6dbc675c89364e26
Author: Kenneth Knowles <[email protected]>
Date: 2016-11-01T04:30:40Z
Refactor and reuse parameter analysis in DoFnSignatures
commit bce430ca73f056365723c6ee19772e2523e166f0
Author: Kenneth Knowles <[email protected]>
Date: 2016-11-01T21:48:54Z
Switch DoFnSignature, etc, from TypeToken to TypeDescriptor
commit a7849497b5d435b3ddb8fba1433164af112f8998
Author: Kenneth Knowles <[email protected]>
Date: 2016-11-01T21:50:24Z
DoFnSignature: Make TypeDescriptor-returning methods public
commit 63f9a3076755d8309481fd13da3f7325f2155b6a
Author: Kenneth Knowles <[email protected]>
Date: 2016-11-01T22:38:01Z
Add TypeDescriptor#getTypes
commit d0724d72584774712b2ea5ff945c65fc84b30d77
Author: Kenneth Knowles <[email protected]>
Date: 2016-11-04T01:42:25Z
Generalize extraction of DoFn parameters from context
commit d90576d91fae041bd980a218344fc3f88a18293a
Author: Kenneth Knowles <[email protected]>
Date: 2016-11-04T02:26:36Z
Switch DoFnInvokersTest to use a mock ExtraContextFactory
commit 5c504d4a6604458e169612a65f098202f7bb3fc7
Author: Kenneth Knowles <[email protected]>
Date: 2016-11-04T02:18:24Z
Add DoFnInvoker dispatch for State and Timer parameters
----
> Add user-ready API for interacting with state
> ---------------------------------------------
>
> Key: BEAM-25
> URL: https://issues.apache.org/jira/browse/BEAM-25
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-core
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Labels: State
>
> Our current state API is targeted at runner implementers, not pipeline
> authors. As such it has many capabilities that are not necessary nor
> desirable for simple use cases of stateful ParDo (such as dynamic state tag
> creation). Implement a simple state intended for user access.
> (Details of our current thoughts in forthcoming design doc)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
