[ 
https://issues.apache.org/jira/browse/BEAM-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15570036#comment-15570036
 ] 

ASF GitHub Bot commented on BEAM-742:
-------------------------------------

GitHub user kennknowles opened a pull request:

    https://github.com/apache/incubator-beam/pull/1089

    [BEAM-742] Replicate triggers to runners-core, favoring commit history over 
blame

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    R: @bjchambers 
    
    This is identical to #1083 but with the first and third commit squashed 
together. Based on my readings on the subject, I would have expected git to 
actually track the content, at least when using blame, but it does not seem to.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/incubator-beam 
TriggerReactor-squashed

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1089.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1089
    
----
commit f63f81e2d8fad16d668809c8b291256ae5477ab1
Author: Kenneth Knowles <k...@google.com>
Date:   2016-06-24T03:05:27Z

    Copy triggers to runners-core
    
    This commit is effectively a "git hint" that all the files
    in runners-core are moved from prior files. The moved files
    will be replaced.

commit f0913147af072cda06a2da4ef6933e311b94dd90
Author: Kenneth Knowles <k...@google.com>
Date:   2016-06-24T03:31:10Z

    Rename trigger reactors

----


> Move trigger state machines to runners-core, convert triggers to AST
> --------------------------------------------------------------------
>
>                 Key: BEAM-742
>                 URL: https://issues.apache.org/jira/browse/BEAM-742
>             Project: Beam
>          Issue Type: Sub-task
>          Components: runner-core, sdk-java-core
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to