[
https://issues.apache.org/jira/browse/BEAM-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15606440#comment-15606440
]
ASF GitHub Bot commented on BEAM-742:
-------------------------------------
GitHub user kennknowles opened a pull request:
https://github.com/apache/incubator-beam/pull/1187
[BEAM-742] Delete the obsolete ExecutableTrigger
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [x] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
R: @aljoscha
Here is the follow-up. Since it makes a trivial but very incompatible
change my goal is to get LGTM on this pull request then (before merging) fix
the integration tests from the Dataflow side.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/incubator-beam
ExecutableTrigger-delete
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1187.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1187
----
commit 16551a8c2913add21ee4587a9acae4f0598bd5be
Author: Kenneth Knowles <[email protected]>
Date: 2016-10-25T20:42:53Z
Delete the obsolete ExecutableTrigger
----
> Move trigger state machines to runners-core, convert triggers to AST
> --------------------------------------------------------------------
>
> Key: BEAM-742
> URL: https://issues.apache.org/jira/browse/BEAM-742
> Project: Beam
> Issue Type: Sub-task
> Components: runner-core, sdk-java-core
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
