[ 
https://issues.apache.org/jira/browse/BEAM-757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15602617#comment-15602617
 ] 

Kenneth Knowles commented on BEAM-757:
--------------------------------------

I'd say you can probably go ahead with it now. Then when I break things I'll 
have to fix them for the Spark runner :-)

I've added a {{SimpleDoFnRunner}} for new {{DoFn}}, and you can use 
{{DoFnRunners.createDefault(Serializable, ...)}} to make the runner agnostic 
about new vs old {{DoFn}}.

See also [the porting of the direct 
runner|https://github.com/apache/incubator-beam/pull/1157/commits/1919d8b3a850bd146137652546da851ee461cd28]
 which now works only with new {{DoFn}}, by adapting old ones. You might be 
able to go straight to that, without the detour through the above method.

> The SparkRunner should utilize the SDK's DoFnRunner instead of writing it's 
> own.
> --------------------------------------------------------------------------------
>
>                 Key: BEAM-757
>                 URL: https://issues.apache.org/jira/browse/BEAM-757
>             Project: Beam
>          Issue Type: Improvement
>          Components: runner-spark
>            Reporter: Amit Sela
>            Assignee: Amit Sela
>
> The SDK now provides DoFnRunner implementations, and so to avoid maintaining 
> against the SDK, the runner should leverage the runner API instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to