[
https://issues.apache.org/jira/browse/BEAM-757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15602671#comment-15602671
]
Amit Sela commented on BEAM-757:
--------------------------------
Yeah, I've noticed that using {{KeyedWorkItem}} means that the input is not
wrapped in {{WindowedValue}} anymore (the elements are, but internally), so my
{{DoFnFunction}}s signature breaks.
Flink seemed to handle this by implementing separate {{DoFnOpertaor}} and
{{WindowDoFnOpertaor}}.
I was going for separate {{DoFnRunner}}s (hence my comment in the PR), but it
definitely makes sense to implement directly.
I'm actually going the way you suggested, but stopped when I hit the
{{DoFnFunction}} issue. Now I think of opening a separate issue to replace
{{OldDoFn}} with {{DoFn}} first, WDYT ?
> The SparkRunner should utilize the SDK's DoFnRunner instead of writing it's
> own.
> --------------------------------------------------------------------------------
>
> Key: BEAM-757
> URL: https://issues.apache.org/jira/browse/BEAM-757
> Project: Beam
> Issue Type: Improvement
> Components: runner-spark
> Reporter: Amit Sela
> Assignee: Amit Sela
>
> The SDK now provides DoFnRunner implementations, and so to avoid maintaining
> against the SDK, the runner should leverage the runner API instead.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
