[
https://issues.apache.org/jira/browse/BEAM-860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15616311#comment-15616311
]
ASF GitHub Bot commented on BEAM-860:
-------------------------------------
GitHub user mizitch opened a pull request:
https://github.com/apache/incubator-beam/pull/1221
[BEAM-860] Move Apache RAT license check out of release profile
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [x] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
Move Apache RAT license check out of release profile. It runs quickly, so
can run as a part of normal mvn verify phase. Will make it so missing licenses
are caught locally more easily.
Tested this locally by removing the license from a file and running 'mvn
clean verify' as well as 'mvn clean verify -P release'. Now both fail, whereas
previously, only 'mvn clean verify -P release' failed.
See discussion at
https://github.com/apache/incubator-beam/pull/1199#issuecomment-256802048
Would you mind looking @dhalperi ? Sorry to send 100% of my two PRs so far
to you, but you do have context on this one...
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mizitch/incubator-beam apache-rat-shift
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1221.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1221
----
commit b6ede84385357da77d2dc3c7b4f04c654ea79b17
Author: Mitch Shanklin <[email protected]>
Date: 2016-10-28T19:20:55Z
Move Apache RAT license check out of release profile. It runs quickly, so
can run as a part of normal mvn verify phase. Will make it so missing licenses
are caught locally more easily.
----
> Move Apache RAT license check out of release profile
> ----------------------------------------------------
>
> Key: BEAM-860
> URL: https://issues.apache.org/jira/browse/BEAM-860
> Project: Beam
> Issue Type: Improvement
> Reporter: Mitch Shanklin
> Assignee: Mitch Shanklin
> Priority: Minor
>
> Currently Apache RAT only checks licenses as a part of the release profile.
> Since the contributor's guide advises users to run 'mvn clean verify' without
> the release profile locally, this means that missing licenses on files are
> caught by Jenkins when they could be caught locally, saving a cycle.
> Since RAT runs quickly, there doesn't seem to be a great reason to keep that
> in the release profile. Seems similar to checkstyle in many respects, which
> is not part of the release profile.
> See https://github.com/apache/incubator-beam/pull/1199#issuecomment-256802048
> for discussion of this issue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
