popduke commented on code in PR #183:
URL: https://github.com/apache/bifromq/pull/183#discussion_r2434665591
##########
base-scheduler/src/main/java/org/apache/bifromq/basescheduler/Batcher.java:
##########
@@ -241,8 +245,8 @@ private IBatchCall<CallT, CallResultT, BatcherKeyT>
borrowBatchCall() {
return batchCall;
}
- private void returnBatchCall(IBatchCall<CallT, CallResultT, BatcherKeyT>
batchCall) {
- batchCall.reset();
+ private void returnBatchCall(IBatchCall<CallT, CallResultT, BatcherKeyT>
batchCall, boolean abort) {
+ batchCall.reset(abort);
Review Comment:
yes, batchcall abortion happens when batcher timed-out getting it's reply,
so backpressure exceptions will be thrown to upper stack. the abort param of
reset is just signaling the impl of batchcall that the reset is called before
the future complete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
