Gujiawei-Edinburgh commented on code in PR #183:
URL: https://github.com/apache/bifromq/pull/183#discussion_r2436183317
##########
bifromq-session-dict/bifromq-session-dict-client/src/main/java/org/apache/bifromq/sessiondict/client/scheduler/BatchSessionExistCall.java:
##########
@@ -45,12 +45,19 @@ public void add(ICallTask<OnlineCheckRequest,
OnlineCheckResult, String> task) {
}
@Override
- public void reset() {
-
+ public void reset(boolean abort) {
+ if (abort) {
+ batchedTasks = new LinkedList<>();
Review Comment:
For batch schedulers, some are Dequeue with length limit some are unbounded.
Here is a linked list. So what is the design tradeoff behind that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
