diegosalvi opened a new pull request, #3489: URL: https://github.com/apache/bookkeeper/pull/3489
Descriptions of the changes in this PR: ### Motivation Is enough common for project to start an embedded version of BK using such classes. Instead of rewrite every time boilerplate code the full server instantiation can be extracted from Main class creating a public API to create BookieService from configurations and/or provided component instances. ### Changes I've took code from Main class and refactored into a builder as EmbeddedServer class. Just providing the configuration to the builder produces the same server that Main class was generating. Added multiple builder properties to permit to inject custom implementations for various components. "Injected" component lifecycle is responsability of the implementor (ie.: if you provide specific instances you need to remember to start and/or stop such instances accordingly) Master Issue: #3488 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
