diegosalvi commented on PR #3489: URL: https://github.com/apache/bookkeeper/pull/3489#issuecomment-1246904547
Righ, it is exactly the case. Il Mer 14 Set 2022, 16:20 Raúl Gracia ***@***.***> ha scritto: > ***@***.**** commented on this pull request. > ------------------------------ > > In > bookkeeper-server/src/main/java/org/apache/bookkeeper/server/EmbeddedServer.java > <https://github.com/apache/bookkeeper/pull/3489#discussion_r970875276>: > > > +import org.apache.bookkeeper.server.service.HttpService; > +import org.apache.bookkeeper.server.service.ScrubberService; > +import org.apache.bookkeeper.server.service.StatsProviderService; > +import org.apache.bookkeeper.stats.StatsLogger; > +import org.apache.bookkeeper.stats.StatsProvider; > +import org.apache.bookkeeper.util.DiskChecker; > +import org.apache.commons.lang3.StringUtils; > + > +/** > + * An embedded server is a server that run bookie and serving rpc requests. > + * > + * <p> > + * It is a rewritten server using ***@***.*** org.apache.bookkeeper.common.component.LifecycleComponent}, replacing the > + * legacy server ***@***.*** org.apache.bookkeeper.proto.BookieServer}. > + */ > +public class EmbeddedServer { > > If I understand correctly, this is embedding the Bookie server and > resources, right? So it can be used both in tests or when running a real > Bookie. I think that I'm in favor of this approach, mainly because it > facilitates testing to other projects using Bookkeeper. For instance, in > this PR I had to do some gymnastics to instantiate test Bookies when > upgrading to Bookkeeper 4.15 in Pravega: pravega/pravega#6676 > <https://github.com/pravega/pravega/pull/6676> > > My understanding is that, with this change, just instantiating a new > EmbeddedServer (maybe the name of the class could be discussed) with the > right configuration, the external code should not care about the resources > of the Bookie itself, right? If this is the case, I think that it is an > improvement in usability. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/bookkeeper/pull/3489#pullrequestreview-1107586467>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AA2R46N34KUN7AVAOA2ELGDV6HNJ7ANCNFSM6AAAAAAQMHOROE> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
