StevenLuMT commented on code in PR #3493:
URL: https://github.com/apache/bookkeeper/pull/3493#discussion_r973927794
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/SortedLedgerStorage.java:
##########
@@ -310,16 +355,19 @@ public void onSizeLimitReached(final Checkpoint cp)
throws IOException {
scheduler.execute(new Runnable() {
@Override
public void run() {
- try {
- LOG.info("Started flushing mem table.");
-
interleavedLedgerStorage.getEntryLogger().prepareEntryMemTableFlush();
- memTable.flush(SortedLedgerStorage.this);
- if
(interleavedLedgerStorage.getEntryLogger().commitEntryMemTableFlush()) {
-
interleavedLedgerStorage.checkpointer.startCheckpoint(cp);
+ for (InterleavedLedgerStorage s :
interleavedLedgerStorageList) {
+ try {
+ LOG.info("Started flushing mem table.");
Review Comment:
finished:
print log's dir
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/SortedLedgerStorage.java:
##########
@@ -310,16 +355,19 @@ public void onSizeLimitReached(final Checkpoint cp)
throws IOException {
scheduler.execute(new Runnable() {
@Override
public void run() {
- try {
- LOG.info("Started flushing mem table.");
-
interleavedLedgerStorage.getEntryLogger().prepareEntryMemTableFlush();
- memTable.flush(SortedLedgerStorage.this);
- if
(interleavedLedgerStorage.getEntryLogger().commitEntryMemTableFlush()) {
-
interleavedLedgerStorage.checkpointer.startCheckpoint(cp);
+ for (InterleavedLedgerStorage s :
interleavedLedgerStorageList) {
+ try {
+ LOG.info("Started flushing mem table.");
+ s.getEntryLogger().prepareEntryMemTableFlush();
+ memTable.flush(SortedLedgerStorage.this);
+
+ if (s.getEntryLogger().commitEntryMemTableFlush()) {
+ s.checkpointer.startCheckpoint(cp);
+ }
+ } catch (Exception e) {
+ s.getStateManager().transitionToReadOnlyMode();
Review Comment:
finished:
print log's dir
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
