[GitHub] [bookkeeper] StevenLuMT commented on a diff in pull request #3493: SortedLedgerStorage supports multiple dirs

Mon, 19 Sep 2022 00:19:57 -0700 


StevenLuMT commented on code in PR #3493:
URL: https://github.com/apache/bookkeeper/pull/3493#discussion_r973931107


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/SortedLedgerStorage.java:
##########
@@ -56,18 +63,22 @@
 
     EntryMemTable memTable;
     private ScheduledExecutorService scheduler;
-    private StateManager stateManager;
     private ServerConfiguration conf;
     private StatsLogger statsLogger;
-    private final InterleavedLedgerStorage interleavedLedgerStorage;
+    protected final List<InterleavedLedgerStorage> 
interleavedLedgerStorageList;
+    private int numberOfDirs;
+    private String interleavedLedgerStorageClazz = 
InterleavedLedgerStorage.class.getName();
 
     public SortedLedgerStorage() {
-        this(new InterleavedLedgerStorage());
+        this(null);
     }
 
     @VisibleForTesting
-    protected SortedLedgerStorage(InterleavedLedgerStorage ils) {
-        interleavedLedgerStorage = ils;
+    protected SortedLedgerStorage(String interleavedLedgerStorageClazz) {

Review Comment:
   this is for InterleavedLedgerStorage's child class: 
SlowInterleavedLedgerStorage
   
   we can init SortedLedgerStorage with overide the diff child 
InterleavedLedgerStorage
   
   <img width="1056" alt="image" 
src="https://user-images.githubusercontent.com/42990025/190967167-61cc57cc-172b-433a-b93c-928f57645883.png";>
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to