StevenLuMT commented on code in PR #3522:
URL: https://github.com/apache/bookkeeper/pull/3522#discussion_r996372095
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieImpl.java:
##########
@@ -935,9 +936,10 @@ private void addEntryInternal(LedgerDescriptor handle,
ByteBuf entry,
// journal `addEntry` should happen after the entry is added to ledger
storage.
// otherwise the journal entry can potentially be rolled before the
ledger is created in ledger storage.
- if (masterKeyCache.get(ledgerId) == null) {
+ if (masterKeyCache.getIfPresent(ledgerId) == null) {
// Force the load into masterKey cache
- byte[] oldValue = masterKeyCache.putIfAbsent(ledgerId, masterKey);
+ byte[] oldValue = masterKeyCache.getIfPresent(ledgerId);
+ masterKeyCache.put(ledgerId, masterKey);
if (oldValue == null) {
Review Comment:
> if we disable it by default nobody will use it, it will fall into the
basket of "experimental features"
@nicoloboschi
yes,I agree @eolivelli , We should use the new logic directly, and the old
logic is a bug, which is easy to cause oom
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
