StevenLuMT commented on PR #3522:
URL: https://github.com/apache/bookkeeper/pull/3522#issuecomment-1281433499

   There are currently 3 schemes for masterKeyCache:
   1. Create a 1 hour guava cache
       Applicable scenarios:       simple to implement;
        Disadvantages:       the granularity of the lock is large, and the data 
structure will be locked when cleaning
   
   2. Use the structure ConcurrentLongHashMap, the key is ledgerId, and the 
value is masterKey;
        Applicable scenarios:      do not set masterKey or masterKey settings 
are mostly the same;
        Disadvantage:       there will be room to enlarge if the same masterKey 
is set for ledgerId
   
   3. Use the structure ConcurrentOpenHashMap, the key is masterKey, the value 
is ledgerId,
   Applicable scenarios:      do not set masterKey or masterKey settings are 
mostly the same
   Disadvantages:      the masterKey settings are different, which increases 
the time-consuming of get/remove
   
   or else I send a email talking ablout it ?
   help me have a look at it @eolivelli @dlg99 @hangc0276 @merlimat 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to