eolivelli commented on PR #3522: URL: https://github.com/apache/bookkeeper/pull/3522#issuecomment-1281954171
I am currently fine with the current approach. I am not sure that there will be a visible performance impact. We should do optimisations like a special path for the empty string in follow up works (if really needed). Regarding the choice of the implementation of the cache...I am not sure that would make a big difference. Maybe we can do with this patch and do more testing and get numbers: it won't be easy as the hot spots in writing to the journal are not for sure about accessing this cache -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
