codelipenghui commented on code in PR #3562:
URL: https://github.com/apache/bookkeeper/pull/3562#discussion_r1000688470
##########
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/api/BookKeeperBuildersTest.java:
##########
@@ -25,6 +25,7 @@
import static org.junit.Assert.assertArrayEquals;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.fail;
+import static org.mockito.Mockito.*;
Review Comment:
Please avoid the star import.
##########
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/api/BookKeeperBuildersTest.java:
##########
@@ -372,6 +375,61 @@ public void testOpenLedgerRecovery() throws Exception {
.execute());
}
+ @Test
+ public void testOpenLedgerNoRecoveryWithTimeoutEx() throws Exception {
+ mockReadEntryTimeout();
+ LedgerMetadata ledgerMetadata = generateLedgerMetadata(ensembleSize,
+ writeQuorumSize, ackQuorumSize, password, customMetadata);
+ registerMockLedgerMetadata(ledgerId, ledgerMetadata);
+ ledgerMetadata.getAllEnsembles().values().forEach(bookieAddressList ->
{
+ bookieAddressList.forEach(bookieAddress -> {
+ registerMockEntryForRead(ledgerId,
BookieProtocol.LAST_ADD_CONFIRMED, bookieAddress, entryData, -1);
+ registerMockEntryForRead(ledgerId, 0, bookieAddress,
entryData, -1);
+ });
+ });
+ try {
+ result(newOpenLedgerOp()
+ .withPassword(ledgerMetadata.getPassword())
+ .withDigestType(DigestType.CRC32)
+ .withLedgerId(ledgerId)
+ .withRecovery(false)
+ .execute());
+ fail("Expect timeout error");
+ } catch (BKException.BKTimeoutException timeoutException) {
+ // Expect timeout error.
+ }
+ // Reset bk client.
+ resetBKClient();
+ }
+
+ @Test
+ public void testOpenLedgerRecoveryWithTimeoutEx() throws Exception {
+ mockReadEntryTimeout();
+ LedgerMetadata ledgerMetadata = generateLedgerMetadata(ensembleSize,
+ writeQuorumSize, ackQuorumSize, password, customMetadata);
+ registerMockLedgerMetadata(ledgerId, ledgerMetadata);
+
+ ledgerMetadata.getAllEnsembles().values().forEach(bookieAddressList ->
{
+ bookieAddressList.forEach(bookieAddress -> {
+ registerMockEntryForRead(ledgerId,
BookieProtocol.LAST_ADD_CONFIRMED, bookieAddress, entryData, -1);
+ registerMockEntryForRead(ledgerId, 0, bookieAddress,
entryData, -1);
+ });
+ });
+ try {
+ result(newOpenLedgerOp()
+ .withPassword(ledgerMetadata.getPassword())
+ .withDigestType(DigestType.CRC32)
+ .withLedgerId(ledgerId)
+ .withRecovery(true)
+ .execute());
+ fail("Expect timeout error");
+ } catch (BKException.BKTimeoutException timeoutException) {
+ // Expect timeout error.
+ }
+ // Reset bk client.
+ resetBKClient();
+ }
Review Comment:
It's better to add a data provider to reduce the duplicated code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
