eolivelli commented on code in PR #3562:
URL: https://github.com/apache/bookkeeper/pull/3562#discussion_r1005474999
##########
pom.xml:
##########
@@ -673,6 +674,11 @@
<artifactId>junit</artifactId>
<version>${junit.version}</version>
</dependency>
+ <dependency>
+ <groupId>com.tngtech.junit.dataprovider</groupId>
Review Comment:
do we really need to add this new dependency ?
in junit4 there is support for parametrised tests
https://github.com/junit-team/junit4/wiki/Parameterized-tests
https://www.testwithspring.com/lesson/writing-parameterized-tests-with-junit-4/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
