gaozhangmin commented on code in PR #3554:
URL: https://github.com/apache/bookkeeper/pull/3554#discussion_r1006405690
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/Auditor.java:
##########
@@ -1328,18 +1326,8 @@ void checkAllLedgers() throws BKException, IOException,
InterruptedException {
final CompletableFuture<Void> processFuture = new
CompletableFuture<>();
Processor<Long> checkLedgersProcessor = (ledgerId, callback) -> {
- try {
- if
(!ledgerUnderreplicationManager.isLedgerReplicationEnabled()) {
- LOG.info("Ledger rereplication has been disabled,
aborting periodic check");
- FutureUtils.complete(processFuture, null);
- return;
- }
- } catch
(ReplicationException.NonRecoverableReplicationException nre) {
- LOG.error("Non Recoverable Exception while reading from
ZK", nre);
- submitShutdownTask();
- return;
Review Comment:
it's handled where `notifyLedgerReplicationStatusChanged` is called
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
