merlimat commented on code in PR #3554:
URL: https://github.com/apache/bookkeeper/pull/3554#discussion_r1013092363
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerUnderreplicationManager.java:
##########
@@ -148,6 +148,18 @@ void enableLedgerReplication()
boolean isLedgerReplicationEnabled()
throws ReplicationException.UnavailableException;
+ /**
+ * Receive notification asynchronously when the ledger replication process
+ * is changed.
+ *
+ * @param cb
+ * - callback implementation to receive the notification
+ */
+ default void notifyLedgerReplicationStatusChanged(GenericCallback<Void> cb)
+ throws ReplicationException.UnavailableException {
+ throw new RuntimeException("not implemented");
Review Comment:
This would be breaking the (runtime) compatibility for an existing
`LedgerUnderReplicationManager` that does not implement the method, since it
will throw exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
