jiazhai commented on code in PR #4035:
URL: https://github.com/apache/bookkeeper/pull/4035#discussion_r1266801044
##########
stream/server/src/main/java/org/apache/bookkeeper/stream/cluster/StreamCluster.java:
##########
@@ -54,23 +42,36 @@
import org.apache.commons.lang3.tuple.Pair;
import org.apache.distributedlog.LocalDLMEmulator;
+import java.io.File;
Review Comment:
seems most of these changes are not needed.
##########
conf/bk_server.conf:
##########
@@ -1065,10 +1065,19 @@ zkEnableSecurity=false
##################################################################
##################################################################
+# The flag enables/disables starting the table service. Default value is
'false'.
+tableServiceEnabled=true
Review Comment:
The default value should be false?
##########
tools/perf/src/main/java/org/apache/bookkeeper/tools/perf/table/PerfClient.java:
##########
@@ -106,7 +106,7 @@ public static class Flags extends CliFlags {
"-nk", "--num-keys"
},
description = "Number of the keys to test")
- public int numKeys = 1000000;
+ public long numKeys = 1000000L;
Review Comment:
Why do we need this change?
##########
stream/server/src/main/java/org/apache/bookkeeper/stream/cluster/StreamCluster.java:
##########
@@ -92,37 +94,38 @@ private static ServerConfiguration
newBookieConfiguration(ServiceURI serviceURI)
private int nextBookiePort;
private int nextGrpcPort;
- private StreamCluster(StreamClusterSpec spec) {
+ public StreamCluster(ServerConfiguration serverConf) {
Review Comment:
We should keep the original "private" instead of making it "public".
##########
conf/bk_server.conf:
##########
@@ -1080,14 +1089,16 @@ dlog.bkcAckQuorumSize=2
### Storage ###
# local storage directories for storing table ranges data (e.g. rocksdb sst
files)
-storage.range.store.dirs=data/bookkeeper/ranges
+storage.range.store.dirs=/tmp/bk-ranges
Review Comment:
Is this needed for this PR? Would you mind keeping it as original?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
