XuQianJin-Stars commented on code in PR #4035:
URL: https://github.com/apache/bookkeeper/pull/4035#discussion_r1268840273
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java:
##########
@@ -4102,4 +4109,113 @@ public ServerConfiguration
setLedgerMetadataRocksdbConf(String ledgerMetadataRoc
this.setProperty(LEDGER_METADATA_ROCKSDB_CONF,
ledgerMetadataRocksdbConf);
return this;
}
+
+ /**
+ * Returns the number of bookies to run in this cluster.
+ *
+ * @return the number of bookies to run in this cluster.
+ */
+ public int getNumBookies() {
+ return getInt(TABLE_NUM_BOOKIES, 1);
+ }
+
+ /**
+ * Set the number of bookies to run in this cluster.
+ *
+ * @param numBookies the number of bookies
+ * @return ServerConfiguration
+ */
+ public ServerConfiguration setNumBookies(int numBookies) {
+ setProperty(TABLE_NUM_BOOKIES, numBookies);
+ return this;
+ }
+
+ /**
+ * Returns if should start zookeeper.
+ *
+ * @return true if should start zookeeper, otherwise false.
+ */
+ public boolean getShouldStartZooKeeper() throws ConfigurationException {
Review Comment:
> Why do we need this one?
use in `StandaloneStarter` to start zookeeper.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
