horizonzy commented on PR #4038: URL: https://github.com/apache/bookkeeper/pull/4038#issuecomment-1659868013
> And i skimmed the changes, seems `if (xxx instance of DefaultEntryLogger)` will resolve it? no need to add this method Using instanceOf is not a good practice, It violates polymorphism. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
