hangc0276 commented on code in PR #4038:
URL: https://github.com/apache/bookkeeper/pull/4038#discussion_r1288158840
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BufferedReadChannel.java:
##########
@@ -43,9 +43,12 @@ public class BufferedReadChannel extends BufferedChannelBase
{
long invocationCount = 0;
long cacheHitCount = 0;
+ private long fileSize = -1;
+ private final boolean sealed;
- public BufferedReadChannel(FileChannel fileChannel, int readCapacity) {
+ public BufferedReadChannel(FileChannel fileChannel, int readCapacity,
boolean sealed) {
Review Comment:
Do we need to keep the original constructor method and create a new one with
`sealed` flag? Because the `BufferedReadChannel` class is public and the
constructor is also public, other applications may use this channel to create
instances. If we change the constructor directly, it will break the
compatibility with the old versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
