dao-jun commented on PR #4259: URL: https://github.com/apache/bookkeeper/pull/4259#issuecomment-2047118889
> I am not familiar with netty reference count. I have two questions. > > 1. why we need `onSendResponseFinished`? Can we just change to `UnsafeByteOperations.unsafeWrap(entryBody.nioBuffer())`? It may leak memory? > 2. I think extract a class field is a little hard to maintenance, can we still pass it by method? @shoothzj 1. `UnsafeByteOperations` is protobufâs API, it will not release the memory, so we have to release it manually. 2. Pass `body` by method will lead to more changes, this is the most simple way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
