lhotari commented on code in PR #4259:
URL: https://github.com/apache/bookkeeper/pull/4259#discussion_r1573270871
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/ReadEntryProcessorV3.java:
##########
@@ -350,6 +344,43 @@ protected void registerEvent(boolean failed, OpStatsLogger
statsLogger, Stopwatc
}
}
+ ByteString parseToByteString(ByteBuf entryBody) {
+ ByteString aggregated = null;
+ ByteString piece;
Review Comment:
Having this variable introduced at this level isn't needed.
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/ReadEntryProcessorV3.java:
##########
@@ -350,6 +344,43 @@ protected void registerEvent(boolean failed, OpStatsLogger
statsLogger, Stopwatc
}
}
+ ByteString parseToByteString(ByteBuf entryBody) {
Review Comment:
The `parse` naming isn't optimal. A better name is `unsafeWrapAsByteString`
etc. It's also worth adding a comment that the lifecycle of the ByteString
continues to be managed with the ByteBuf lifecycle (retain/release).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
