hangc0276 commented on code in PR #4555:
URL: https://github.com/apache/bookkeeper/pull/4555#discussion_r1972975429
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java:
##########
@@ -470,6 +473,10 @@ public void runWithFlags(boolean force, boolean
suspendMajor, boolean suspendMin
gcStats.getMajorCompactionCounter().inc();
majorCompacting.set(false);
}
+ if (entryLocationCompaction) {
Review Comment:
I suggest moving the entryLocationCompact out of the major or minor
compaction scope and using a separate interval to control it. Remove the
`entryLocationCompaction` flag and use the entryLocationCompactionInterval
instead. The default value is `-1`, which means disable. We can set it to 1
week by default in the future after verified this operation doesn't introduce a
huge impact on performance.
The major or minor compaction has many impact factors, such as suspension,
force, and interval. It will make the entryLocation compaction behavior
unpredictable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
