danpi commented on code in PR #4555:
URL: https://github.com/apache/bookkeeper/pull/4555#discussion_r1980651974
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java:
##########
@@ -470,6 +473,10 @@ public void runWithFlags(boolean force, boolean
suspendMajor, boolean suspendMin
gcStats.getMajorCompactionCounter().inc();
majorCompacting.set(false);
}
+ if (entryLocationCompaction) {
Review Comment:
Great suggestion! Currently, the execution of `entryLocationCompact` is
indeed coupled with the triggering of `majorCompaction`. I will modify it so
that `entryLocationCompact` execution is only based on the configured trigger
interval.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
