Re: [PR] Fixed issue where entries could not be read due to mismatch between the ensemble on metadata and the actual written bookies. [bookkeeper]

Thu, 06 Nov 2025 17:59:55 -0800 


shustsud commented on code in PR #4194:
URL: https://github.com/apache/bookkeeper/pull/4194#discussion_r2501435038


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java:
##########
@@ -2290,8 +2292,9 @@ void ensembleChangeLoop(List<BookieId> origEnsemble, 
Map<Integer, BookieId> fail
                             ensembleChangeLoop(origEnsemble, toReplace);
                         }
 
-                        if (newEnsemble != null) { // unsetSuccess outside of 
lock

Review Comment:
   Sorry for the late reply.
   
   I believe the current code should not cause a deadlock, but I agree that 
calling `unsetSuccessAndSendWriteRequest` inside the lock might not be ideal.
   I'll check whether it’s possible to safely move the 
`unsetSuccessAndSendWriteRequest` call outside the lock.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to