shustsud commented on code in PR #4194:
URL: https://github.com/apache/bookkeeper/pull/4194#discussion_r2532795532
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java:
##########
@@ -2290,8 +2292,9 @@ void ensembleChangeLoop(List<BookieId> origEnsemble,
Map<Integer, BookieId> fail
ensembleChangeLoop(origEnsemble, toReplace);
}
- if (newEnsemble != null) { // unsetSuccess outside of
lock
Review Comment:
@lhotari
I've updated the code to move the unsetSuccessAndSendWriteRequest() call
outside the metadataLock, as I mentioned before.
Please take another look when you have a chance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
