gtristan commented on PR #15: URL: https://github.com/apache/buildstream-plugins/pull/15#issuecomment-1173503077
I think this branch is OK to land. I'd note that the commit which avoids downloading crates at track time for which we already have a `sha` is a discrepancy in behavior when compared with sources like `tar`, which are expected to derive the `sha` from the remote unconditionally (and print a warning in the case that an existing `sha` is *changed*). Cargo is sufficiently different, inasmuch as it may make sense to *track* the cargo source even when some of the `sha`s are already known locally but not all of them are known. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
