abderrahim commented on PR #15: URL: https://github.com/apache/buildstream-plugins/pull/15#issuecomment-1173542005
> I'd note that the commit which avoids downloading crates at track time for which we already have a `sha` is a discrepancy in behavior when compared with sources like `tar`, which are expected to derive the `sha` from the remote unconditionally (and print a warning in the case that an existing `sha` is _changed_). Maybe I'll let your past self answer the question: https://gitlab.com/BuildStream/bst-external/-/merge_requests/157#note_836698782 Either way, we don't use the sha that is already tracked (or at least, that's not the intent) but rather the sha that is available in the Cargo.lock file that we're using. To put it differently, we're tracking the Cargo.lock, not the remot.. This is not exactly correct for tar either. tar has a shortcut that makes it not download unconditionally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
