gtristan commented on code in PR #1671:
URL: https://github.com/apache/buildstream/pull/1671#discussion_r913058304
##########
src/buildstream/_cas/casdprocessmanager.py:
##########
@@ -92,6 +106,60 @@ def __init__(self, path, log_dir, log_level, cache_quota,
remote_cache_spec, pro
casd_args, cwd=path, stdout=logfile_fp,
stderr=subprocess.STDOUT, preexec_fn=os.setpgrp
)
+ # _check_casd_version()
+ #
+ # Check for minimal acceptable version of buildbox-casd.
+ #
+ # If the version is unacceptable, then an error is raised.
+ #
+ # If buildbox-casd was built without version information available (or has
reported
+ # version information with a string which we are unprepared to parse), then
+ # a warning is produced to inform the user.
+ #
+ def _check_casd_version(self, messenger):
+ #
+ # We specify a trailing "path" argument because some versions of
buildbox-casd
+ # require specifying the storage path even for invoking the --version
option.
+ #
+ casd_args = [utils.get_host_tool("buildbox-casd")]
+ casd_args.append("--version")
+ casd_args.append("/")
Review Comment:
The comment already reads:
```
#
# We specify a trailing "path" argument because some versions of
buildbox-casd
# require specifying the storage path even for invoking the
--version option.
#
```
And the issue was raised here:
https://gitlab.com/BuildGrid/buildbox/buildbox-casd/-/issues/86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
