gtristan commented on PR #1671: URL: https://github.com/apache/buildstream/pull/1671#issuecomment-1174989616
> Can we do something similar about buildbox-fuse? Some of this requires addressing more of https://gitlab.com/BuildGrid/buildbox/buildbox-casd/-/issues/86, `buildbox-run` for instance I believe does not yet expose a `--version` argument, it would be best to have the command line parsing code in `buildbox-common` automatically support a `--version` argument and update all the binaries to provide a version (this might require updating the relevant components with similar CMake foo to derive their versions from git tags, falling back to "unknown"). For `buildbox-fuse` I'm not sure it makes sense to do anything about this, as we do not directly *invoke* `buildbox-fuse` - I guess that this is more of an implementation detail of `buildbox` and we don't really have any business knowing that it exists. That said, on the one hand it seems unimportant since `buildbox` binaries should generally be distributed/updated together, but on the other hand if this is the case, it leaves us open to problems which occur when `buildbox-fuse/buildbox-run` are updated but `buildbox-casd` has *not* been updated and so there is no new version to test for. Probably it is best to at least: * Have a separate version check for `buildbox-run` * Expect that `buildbox-run` will bump it's *own* version number if an important change is introduced in the `buildbox-fuse` implementation detail -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
