gtristan commented on PR #1706:
URL: https://github.com/apache/buildstream/pull/1706#issuecomment-1197743747
> In general I'm not fond of this refactor.
I had further conversation with @juergbi on this and it's better to update
the issue.
Main points are:
* I'd like to keep the separation of `Job` and `ElementJob` for reasons
stated above
* I agree that the simplification of `job.py` and elimination of the
separate `ChildJob` object is desirable, as I believe the first patch in this
branch achieves
* I'm a little concerned about this patch, just because it appears to
touch on task termination logic. BuildStream suspension and termination,
especially in interactive scenarios, is really not very well covered in the
test suite, so I would just appreciate that some creative interactive testing
be done to avoid regressions on this front.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
