abderrahim commented on code in PR #1706:
URL: https://github.com/apache/buildstream/pull/1706#discussion_r1306998548
##########
src/buildstream/_scheduler/job.py:
##########
@@ -322,111 +271,23 @@ async def _parent_child_completed(self, returncode):
else:
status = JobStatus.FAIL
- self.parent_complete(status, self._result)
+ self._complete_cb(self, self._element, status, self._result)
Review Comment:
I skipped this as after removing the element job, we're still using
subclasses and overrides. Let's do the rename later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
