gtristan commented on code in PR #1746:
URL: https://github.com/apache/buildstream/pull/1746#discussion_r959813893
##########
src/buildstream/_platform/platform.py:
##########
@@ -44,16 +44,16 @@ def _setup_sandbox(self):
# Try to setup buildbox-run sandbox, otherwise fallback to the dummy
sandbox.
try:
self._check_sandbox(SandboxBuildBoxRun)
- except (SandboxError, utils.ProgramNotFoundError):
+ except (SandboxUnsupportedError, utils.ProgramNotFoundError):
pass
def _check_sandbox(self, Sandbox):
Sandbox._dummy_reasons = []
try:
Sandbox.check_available()
- except SandboxError as Error:
+ except SandboxUnsupportedError as Error:
Review Comment:
Also in the line below we are collecting this weird reasons list of strings,
it appears to be the last place justifying the existence of this
`Sandbox._dummy_reasons` variable, any chance we can take this opportunity to
get rid of it ? (Not sure we need this similar variable
`Platform.dummy_reasons` either).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
